HDDS-10907. DataNode StorageContainerMetrics numWriteChunk is counted multiple times #6835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seem that adding the test in TestContainerMetrics is better. I'll update it later. |
jojochuang
reviewed
Jun 24, 2024
...service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/ContainerMetrics.java
Outdated
Show resolved
Hide resolved
| ContainerTestHelper.getWriteChunkRequest( | ||
| pipeline, blockID, 1024); | ||
| ContainerCommandResponseProto response = | ||
| client.sendCommand(writeChunkRequest); | ||
| ContainerCommandResponseProto response = client.sendCommand(writeChunkRequest); | ||
| assertEquals(ContainerProtos.Result.SUCCESS, |
There was a problem hiding this comment.
we should check the related metrics in containerMetrics are correct. In specific, make sure numWriteChunk is expected.
There was a problem hiding this comment.
Here are some assertions for containerMetrics:
Is it enough?
|
@jojochuang CI passed, in case you want to merge |
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 26, 2024
… multiple times (apache#6835) Co-authored-by: Doroszlai, Attila <adoroszlai@apache.org> (cherry picked from commit 63a232b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
StorageContainerMetrics.incContainerOpsMetrics() updates operation counts. It is incremented not just once for WriteChunk, because it is called by HddsDispatcher.dispatchRequest() during WRITE_DATA (by ContainerStateMachine.writeStateMachineData()) and COMMIT_DATA phase.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10907
How was this patch tested?
Add assertion of containerMetrics in
TestBlockOutputStream